Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix cosign image signing after breaking changes #1047

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: fix cosign image signing after breaking changes #1047

merged 1 commit into from
Mar 16, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 14, 2023

This PR

  • fixes some issues with cosign during signing and verification by signing the image by digest and not by tag
  • verification of images behind the released tags should still be possible with this solution

@github-actions github-actions bot added the ops label Mar 14, 2023
@netlify
Copy link

netlify bot commented Mar 14, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 657da0a
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6410717838533b00084edbbb
😎 Deploy Preview https://deploy-preview-1047--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies changed the title ci: adapt to breaking changes in cosign fix: fix cosign after breaking changes Mar 16, 2023
@mowies mowies changed the title fix: fix cosign after breaking changes fix: fix cosign image signing after breaking changes Mar 16, 2023
@thisthat thisthat merged commit e5abf85 into keptn:main Mar 16, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@thisthat thisthat thisthat approved these changes

@thschue thschue Awaiting requested review from thschue

@philipp-hinteregger philipp-hinteregger Awaiting requested review from philipp-hinteregger

Assignees
No one assigned
Labels
ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mowies @thisthat @bacherfl