fix: added metric-operator prefix to related ClusterRole and ClusterRoleBindings #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oleBindings Signed-off-by: Florian Bacher <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
==========================================
+ Coverage 56.61% 58.69% +2.07%
==========================================
Files 92 124 +32
Lines 8520 9910 +1390
==========================================
+ Hits 4824 5817 +993
- Misses 3564 3880 +316
- Partials 132 213 +81 see 36 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
approved these changes
Mar 13, 2023
thisthat
approved these changes
Mar 13, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
metrics-operatorprefix to the ClusterRole and ClusterRoleBinding required by the HPA to read KeptnMetrics. The resulting names are now:The name of the ClusterRoleBinding has been changed to avoid errors when upgrading from the previous version, due to the limitation of not being able to change the roleRef of an existing ClusterRoleBinding