Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove missing 404 bug #1006

Merged
merged 11 commits into from
Mar 9, 2023
Merged

fix: remove missing 404 bug #1006

merged 11 commits into from
Mar 9, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 8, 2023

make sure that metrics operator returns status code in case of error and not empty values
image
line 3 metrics not there, line 4 metric there but empty

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit b22ede2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6408661676605200084afcc9
😎 Deploy Preview https://deploy-preview-1006--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1006 (231de9e) into main (444ba74) will increase coverage by 0.57%.
The diff coverage is 93.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   57.38%   57.96%   +0.57%     
==========================================
  Files         119      126       +7     
  Lines        9914    10117     +203     
==========================================
+ Hits         5689     5864     +175     
- Misses       4027     4045      +18     
- Partials      198      208      +10     
Impacted Files Coverage Δ
metrics-operator/pkg/metrics/server.go 64.88% <93.33%> (-3.92%) ⬇️
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 54.94% <0.00%> (-3.30%) ⬇️
...ollers/lifecycle/keptntaskdefinition/controller.go 92.00% <0.00%> (ø)
...ecycle/v1alpha3/keptnevaluationprovider_webhook.go 0.00% <0.00%> (ø)
.../controllers/lifecycle/keptnworkload/controller.go 67.08% <0.00%> (ø)
...ifecycle/v1alpha3/keptnworkloadinstance_webhook.go 0.00% <0.00%> (ø)
...ifecycle/keptntaskdefinition/reconcile_function.go 72.72% <0.00%> (ø)
...erator/apis/lifecycle/v1alpha3/keptnapp_webhook.go 0.00% <0.00%> (ø)
... and 7 more
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
lifecycle-operator 53.63% <ø> (ø)
metrics-operator 62.55% <93.33%> (-0.44%) ⬇️
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna force-pushed the fix/983/metrics_return_404 branch from b22ede2 to b56d87f Compare March 8, 2023 11:38
@mowies mowies changed the title fix: removes missing 404 bug fix: remove missing 404 bug Mar 8, 2023
@RealAnna RealAnna marked this pull request as draft March 9, 2023 06:29
RealAnna added 2 commits March 9, 2023 07:39
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
@RealAnna RealAnna marked this pull request as ready for review March 9, 2023 06:45
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
@RealAnna RealAnna force-pushed the fix/983/metrics_return_404 branch from affc0f1 to c16860e Compare March 9, 2023 09:21
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit e8c0f38 into main Mar 9, 2023
@RealAnna RealAnna deleted the fix/983/metrics_return_404 branch March 9, 2023 09:43
@keptn-bot keptn-bot mentioned this pull request Mar 9, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants