From 84ae464abc789d4d464301ffd4e266136c60046b Mon Sep 17 00:00:00 2001 From: Sagar Rawat <116507833+SagarRawat24@users.noreply.github.com> Date: Tue, 26 Sep 2023 14:46:45 +0530 Subject: [PATCH] docs: update contribution guideline link in PR template (#2003) --- .github/PULL_REQUEST_TEMPLATE/pr-template.md | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pr-template.md b/.github/PULL_REQUEST_TEMPLATE/pr-template.md index 52cd454bf2..753383a7f6 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pr-template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pr-template.md @@ -26,16 +26,15 @@ Please also provide information about any automatic tests that you added. - [ ] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated into multiple PRs) - [ ] I used descriptive commit messages to help reviewers understand my thought process -- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO) ( - see [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/CONTRIBUTING.md#submit-a-pull-request-)) +- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO) + see [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines) - [ ] My PR title is formatted according to the semantic PR conventions described in - the [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/CONTRIBUTING.md#submit-a-pull-request-) + the [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines) - [ ] My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes) - [ ] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable) - [ ] I have performed a self-review of my code - [ ] I have made corresponding changes to the documentation (if needed) -- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test - runs) +- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs) - [ ] New and existing unit and integration tests pass locally with my changes <!-- DOCS SECTION --> @@ -54,13 +53,12 @@ Fixes # (issue) - [ ] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated into multiple PRs) - [ ] I used descriptive commit messages to help reviewers understand my thought process -- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO) ( - see [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/docs/CONTRIBUTING.md#developer-certification-of-origin-dco)) +- [ ] I signed off all my commits according to the Developer Certificate of Origin (DCO)( + see [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines)) - [ ] My PR title is formatted according to the semantic PR conventions described in - the [Contribution Guide](https://github.com/keptn/lifecycle-toolkit/blob/main/CONTRIBUTING.md#submit-a-pull-request-) + the [Contribution Guide](https://lifecycle.keptn.sh/contribute/docs/contribution-guidelines) - [ ] My content follows the style guidelines of this project (YAMLLint, markdown-lint) - [ ] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable) - [ ] I have performed a self-review of my content including grammar and typo errors and also checked the rendered page from the Netlify deploy preview -- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test - runs) +- [ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)