This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
feat(bridge): Allow to configure sendStarted flag for webhook config #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
ermin-muratovic
force-pushed
the
feature/6059/send-started-event-flag-webhook
branch
from
156e967 to
7045f5f
Compare
Signed-off-by: ermin.muratovic <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7183 +/- ##
==========================================
+ Coverage 58.55% 58.56% +0.01%
==========================================
Files 528 528
Lines 30744 30753 +9
Branches 1508 1508
==========================================
+ Hits 18001 18010 +9
Misses 11474 11474
Partials 1269 1269
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: ermin.muratovic <[email protected]>
…false Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
laneli
reviewed
Mar 25, 2022
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.spec.ts
Outdated
Show resolved
Hide resolved
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.spec.ts
Outdated
Show resolved
Hide resolved
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.spec.ts
Outdated
Show resolved
Hide resolved
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.spec.ts
Outdated
Show resolved
Hide resolved
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
laneli
reviewed
Mar 29, 2022
| .assertIsSendFinishedButtonsEnabled(true) | ||
| .assertIsSendStarted(true) | ||
| .assertIsSendFinished(true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Please add an additional test, to test for retrieved values, if the checkboxes are set correctly
There was a problem hiding this comment.
UI tests are added ;)
Signed-off-by: ermin.muratovic <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
laneli
approved these changes
Mar 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #6059