Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Fix no-services message and link #7035

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Mar 2, 2022

Fixes #6997

The link now redirects to the create service page (so it's the same behavior as in the create project success notification).
On service creation, the user is redirected back to the environment page.

image

Signed-off-by: Klaus Strießnig [email protected]

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #7035 (a30c335) into master (d1b96ef) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7035      +/-   ##
==========================================
- Coverage   57.86%   57.85%   -0.01%     
==========================================
  Files         512      512              
  Lines       29722    29725       +3     
  Branches     1408     1408              
==========================================
  Hits        17198    17198              
- Misses      11292    11294       +2     
- Partials     1232     1233       +1     
Impacted Files Coverage Δ
...no-service-info/ktb-no-service-info.component.html 100.00% <ø> (ø)
...b-no-service-info/ktb-no-service-info.component.ts 100.00% <100.00%> (ø)
distributor/pkg/uniform/log/uniformlog.go 71.87% <0.00%> (-4.69%) ⬇️
Flag Coverage Δ
bridge-server 58.30% <ø> (ø)
bridge2 73.43% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Klaus Strießnig <[email protected]>
ermin-muratovic
ermin-muratovic previously approved these changes Mar 2, 2022
Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ermin-muratovic ermin-muratovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kirdock Kirdock merged commit c9e58a7 into master Mar 9, 2022
@Kirdock Kirdock deleted the fix/6997/fix-no-service-message branch March 9, 2022 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty project leads user to wrong "Create service" link
2 participants