Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat(webhook-service): Allow disabling .started events (#6524) #6664

Merged
merged 6 commits into from
Jan 25, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jan 24, 2022

@bacherfl bacherfl added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #6664 (3a92b60) into master (8c2d8de) will increase coverage by 0.02%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #6664      +/-   ##
==========================================
+ Coverage   56.71%   56.74%   +0.02%     
==========================================
  Files         496      496              
  Lines       28391    28401      +10     
  Branches     1301     1301              
==========================================
+ Hits        16103    16116      +13     
+ Misses      11074    11072       -2     
+ Partials     1214     1213       -1     
Impacted Files Coverage Δ
webhook-service/handler/handler.go 84.18% <85.71%> (+0.24%) ⬆️
webhook-service/lib/webhook_config.go 66.66% <100.00%> (+11.66%) ⬆️
distributor/pkg/lib/controlplane/uniformlog.go 76.56% <0.00%> (+4.68%) ⬆️
Flag Coverage Δ
approval-service 71.92% <ø> (ø)
bridge-server 49.44% <ø> (ø)
cli 42.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review January 25, 2022 07:57
@bacherfl bacherfl requested a review from a team as a code owner January 25, 2022 07:57
odubajDT
odubajDT previously approved these changes Jan 25, 2022
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait with merging until the integration tests are finished

Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit e07091f into master Jan 25, 2022
@bacherfl bacherfl deleted the feat/6524/webhook-started-events branch January 25, 2022 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core: Allow WebHook to do not send started events
2 participants