Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat: Resource service endpoint handler implementation(#6346) #6461

Merged
merged 44 commits into from
Jan 4, 2022
Merged

feat: Resource service endpoint handler implementation(#6346) #6461

merged 44 commits into from
Jan 4, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jan 3, 2022

No description provided.

bacherfl and others added 27 commits December 21, 2021 16:31
@bacherfl
added swagger doc comments for resource handler endpoints
1a52759 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added interface definitions and error types
96e8176 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added unit tests for project/stage handlers
e375158 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added unit tests for project/stage/service handlers
cf3a1ce 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added unit tests for project/stage/service handlers
da5da84 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added unit tests for project resource handler
c3a7fa0 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
refactoring, additional unit tests
a2ccc7d 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
refactoring, additional unit tests
e623ead 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
stage resource handler tests
c74dd38 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
service resource handler implementation
da55983 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
service resource handler unit tests
f6429d1 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added stubs for implementations
973cda6 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
added utils
c0f357a 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
implemented and tested project manager
2503a9b 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
implemented and tested stage/service manager
10ecdf2 
Signed-off-by: Florian Bacher <[email protected]>
@odubajDT
feat: added API documentation (#6448)
a66abd9 
* initial version of main.go

Signed-off-by: odubajDT <[email protected]>

* first working version

Signed-off-by: odubajDT <[email protected]>

* deploy service configuration-service

Signed-off-by: odubajDT <[email protected]>

* disable liveness and readiness probe

Signed-off-by: odubajDT <[email protected]>

* API documentation working

Signed-off-by: odubajDT <[email protected]>

* update go.mod and go.sum

Signed-off-by: odubajDT <[email protected]>
@bacherfl
unit tests for service manager
6b821b1 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
Merge remote-tracking branch 'origin/feat/resource-service-endpoints'…
fdc8be3 
… into feat/resource-service-endpoints
@bacherfl
introduce response type for write operations
c00b434 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
refactorings
e0edebf 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
refactorings
0dfe382 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
extract common functionality to resource_engine
a9129e9 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
extract common functionality
94d161c 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
adapted return types of write resource handlers
48ebb2d 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
introduce general resource manager
352a6a9 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
additional tests
14ee4c4 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
additional tests
3678ebf 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl changed the title Feat/resource service endpoints feat: Resource service endpoint handler implementation Jan 3, 2022
@bacherfl bacherfl changed the title feat: Resource service endpoint handler implementation feat: Resource service endpoint handler implementation(#6346) Jan 3, 2022
@bacherfl
additional tests
6034842 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl force-pushed the feat/resource-service-endpoints branch from 8e7b85c to 6034842 Compare January 3, 2022 09:43
@codecov
Copy link

codecov bot commented Jan 3, 2022 •
edited
Loading

Codecov Report

Merging #6461 (0396421) into master (b6b4ac2) will decrease coverage by 1.06%.
The diff coverage is 92.15%.

❗ Current head 0396421 differs from pull request most recent head d6af1c3. Consider uploading reports for the commit d6af1c3 to get more accurate results

@@            Coverage Diff             @@
##           master    #6461      +/-   ##
==========================================
- Coverage   57.74%   56.68%   -1.07%     
==========================================
  Files         464      359     -105     
  Lines       26473    24257    -2216     
  Branches     1810     1167     -643     
==========================================
- Hits        15286    13749    -1537     
+ Misses      10161     9483     -678     
+ Partials     1026     1025       -1
Impacted Files Coverage Δ
resource-service/common/git.go 63.58% <ø> (ø)
resource-service/common/files.go 50.81% <50.81%> (ø)
resource-service/common/mutex.go 72.22% <72.22%> (ø)
resource-service/handler/pagination.go 85.00% <85.00%> (ø)
resource-service/handler/resource_manager.go 92.89% <92.89%> (ø)
resource-service/handler/stage_manager.go 93.75% <93.54%> (ø)
...source-service/handler/project_resource_handler.go 97.18% <96.94%> (ø)
...source-service/handler/service_resource_handler.go 97.40% <97.20%> (ø)
resource-service/handler/project_manager.go 97.27% <97.24%> (ø)
resource-service/handler/stage_resource_handler.go 97.29% <97.29%> (ø)
... and 216 more

bacherfl added 11 commits January 3, 2022 13:40
@bacherfl
additional tests
8bb3b77 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
Merge branch 'master' into feat/resource-service-endpoints
5979874 
# Conflicts:
#	resource-service/go.mod
#	resource-service/go.sum
@bacherfl
remove obsolete code
4f8c9f9 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
additional tests
a8fce8d 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
wire up components
955c401 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
additional tests for increased coverage
cdbd8ea 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
introduce type for common properties
5545f7a 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
error logging
cfb2be0 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
remove parseDependency flag from swag init
ccb9d48 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
Merge branch 'master' into feat/resource-service-endpoints
4eb346d 
# Conflicts:
#	resource-service/common/credentials.go
#	resource-service/common/credentials_test.go
#	resource-service/common/fake/git_mock.go
#	resource-service/common/git.go
#	resource-service/errors/errors.go
#	resource-service/go.mod
#	resource-service/go.sum
@bacherfl
fixed merge conflicts
f8d751f 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
clean up todos
0e2c347 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl marked this pull request as ready for review January 4, 2022 13:34
@odubajDT @bacherfl
feat: added API documentation (#6448)
d6af1c3 
* initial version of main.go

Signed-off-by: odubajDT <[email protected]>

* first working version

Signed-off-by: odubajDT <[email protected]>

* deploy service configuration-service

Signed-off-by: odubajDT <[email protected]>

* disable liveness and readiness probe

Signed-off-by: odubajDT <[email protected]>

* API documentation working

Signed-off-by: odubajDT <[email protected]>

* update go.mod and go.sum

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl force-pushed the feat/resource-service-endpoints branch from 0396421 to d6af1c3 Compare January 4, 2022 13:52
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.9% 6.9% Duplication

RealAnna
RealAnna approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacherfl bacherfl merged commit e19ed7b into master Jan 4, 2022
@bacherfl bacherfl deleted the feat/resource-service-endpoints branch January 4, 2022 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@RealAnna RealAnna RealAnna approved these changes

@christian-kreuzberger-dtx christian-kreuzberger-dtx Awaiting requested review from christian-kreuzberger-dtx christian-kreuzberger-dtx is a code owner

@mowies mowies Awaiting requested review from mowies mowies is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bacherfl @RealAnna @odubajDT