Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Question: Why is the evaluation result dropped from one stage to the next? #6167

Closed
johannes-b opened this issue Nov 24, 2021 · 3 comments
Closed
Assignees
Labels
support Support/Questions type:bug Something is not working as intended/documented
Milestone

Comments

@johannes-b
Copy link
Member

Use case

As a user, I have an approval task set as first task in my delivery sequence of production:

apiVersion: "spec.keptn.sh/0.2.2"
kind: "Shipyard"
metadata:
  name: "shipyard-sockshop"
spec:
  stages:

    - name: "staging"
      sequences:
        - name: "delivery"
          triggeredOn:
            - event: "dev.delivery.finished"
          tasks:
            - name: "deployment"
              properties:
                deploymentstrategy: "blue_green_service"
            - name: "test"
              properties:
                teststrategy: "performance"
            - name: "evaluation"
            - name: "release"
            - name: "approval"
              properties:
                pass: "manual"
                warning: "manual"

    - name: "production"
      sequences:
        - name: "delivery"
          triggeredOn:
            - event: "staging.delivery.finished"
          tasks:
            - name: "approval"
              properties:
                pass: "manual"
                warning: "manual"
            - name: "deployment"
              properties:
                deploymentstrategy: "blue_green_service"
            - name: "release"

I'm used to the behavior that the approval task shows the last evaluation result:

image

However, when using the approval task as the first task, the evaluation score is not shown.

image

Investigation

I figured out that during the promotion from staging to production, the score:100 dropped to 0. Why is this done?

In staging:
image

In production:
image

@ghost
Copy link

ghost commented Nov 24, 2021

Move to discussions?

@thisthat thisthat added the type:bug Something is not working as intended/documented label Dec 2, 2021
@johannes-b
Copy link
Member Author

It has been sorted out by the team that here data is getting lost due to implementation in the shipyard-controller. This is marked as bug now.

@johannes-b johannes-b added this to the 0.13.0 milestone Dec 6, 2021
@RealAnna RealAnna self-assigned this Dec 14, 2021
@RealAnna
Copy link
Contributor

image
I tested the same shipyard on my cluster running 0.11.3 and the score is correctly propagated. I believe the issue has been solved here #5691

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
support Support/Questions type:bug Something is not working as intended/documented
Projects
None yet
Development

No branches or pull requests

3 participants