Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore(shipyard-controller): cleaning up package(s) #5786

Merged
merged 12 commits into from
Oct 27, 2021

Conversation

warber
Copy link
Contributor

@warber warber commented Oct 25, 2021

Cleanup:

  • get rid of events/stages/servcies/projects operation interfaces
  • cleaned up DB repo (renamed files and put interfaces in single file)
  • removed sequence started and sequence control channels
  • removed operations package

@warber warber requested a review from a team as a code owner October 25, 2021 11:55
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #5786 (7e2dfe5) into master (ee27c62) will decrease coverage by 0.58%.
The diff coverage is 79.79%.

@@            Coverage Diff             @@
##           master    #5786      +/-   ##
==========================================
- Coverage   54.15%   53.56%   -0.59%     
==========================================
  Files         389      317      -72     
  Lines       22636    22138     -498     
  Branches      967      985      +18     
==========================================
- Hits        12258    11859     -399     
+ Misses       9466     9379      -87     
+ Partials      912      900      -12     
Impacted Files Coverage Δ
shipyard-controller/db/mongodb_event_repo.go 51.23% <ø> (ø)
shipyard-controller/db/mongodb_log_repo.go 57.03% <ø> (ø)
shipyard-controller/db/mongodb_project_repo.go 1.57% <ø> (ø)
shipyard-controller/db/mongodb_state_repo.go 70.39% <ø> (ø)
shipyard-controller/db/mongodb_uniform_repo.go 64.43% <ø> (ø)
shipyard-controller/handler/statehandler.go 40.90% <0.00%> (ø)
shipyard-controller/main.go 5.82% <0.00%> (+0.11%) ⬆️
shipyard-controller/handler/eventdispatcher.go 63.15% <66.66%> (ø)
shipyard-controller/handler/sequencedispatcher.go 68.25% <66.66%> (ø)
shipyard-controller/handler/shipyardcontroller.go 61.15% <69.23%> (+0.26%) ⬆️
... and 89 more

bacherfl
bacherfl previously approved these changes Oct 25, 2021
@warber warber changed the title chore(shipyard-controller): cleaning up db package chore(shipyard-controller): cleaning up package(s) Oct 27, 2021
bacherfl
bacherfl previously approved these changes Oct 27, 2021
@warber warber added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Oct 27, 2021
Signed-off-by: warber <[email protected]>
@warber warber force-pushed the patch/5243/shipyard-controller-cleanup-1 branch from 8775902 to 770799d Compare October 27, 2021 08:23
@warber warber removed the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Oct 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2021

Docker Build Report

  • Pushed keptn/shipyard-controller:0.10.0-dev-PR-5786.202110270931 and keptn/shipyard-controller:0.10.0-dev-PR-5786 (Source: shipyard-controller/)

@warber warber merged commit a6e51d4 into master Oct 27, 2021
@warber warber deleted the patch/5243/shipyard-controller-cleanup-1 branch October 27, 2021 10:31
carpe-github pushed a commit to carpe-github/keptn that referenced this pull request Nov 4, 2021
* get rid of events/stages/servcies/projects operation interfaces
* cleaned up DB repo (renamed files and put interfaces in single file)
* removed sequence started and sequence control channels
* removed operations package
* other minor cleanups

Signed-off-by: warber <[email protected]>
Signed-off-by: Gevorg Iskandaryan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants