This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix: change SLO values for new podtatohead image #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TannerGabriel <[email protected]>
TannerGabriel
requested review from
AloisReitbauer and
christian-kreuzberger-dtx
as code owners
|
@thisthat please have a look or assign to the team |
thisthat
changed the title
thisthat
suggested changes
Oct 27, 2021
Signed-off-by: TannerGabriel <[email protected]>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
The SLO file for the quickstart example and the podtatohead version used are out of sync. The SLO file checks for an HTTP response time of 1 second, but the actual delay of the used podatohead is only 200ms and does therefore not trigger the SLO criteria.
The PR fixes this problem by reducing the SLO time to 200ms.
How to test
Run the quickstart guide using the new SLO file.