Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler): Create new context when starting background routine for pod checks #148

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Oct 12, 2022

This PR solves the problem of running into the dynamic client's rate limiter due to the context already being cancelled outside of the permit function

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 543ca87 into main Oct 12, 2022
@thschue thschue deleted the fix/scheduler-client-ratelimit branch October 12, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants