Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scheduler): Add support for OTel collector #146

Merged
merged 2 commits into from
Oct 12, 2022
Merged

feat(scheduler): Add support for OTel collector #146

merged 2 commits into from
Oct 12, 2022

Conversation

bacherfl
Copy link
Member

Note: The PR #145 contains a tutorial to make use of this feature
Signed-off-by: Florian Bacher [email protected]

thisthat
thisthat reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would have expected to see something in the go.mod about the new OTel Exporter and grcp

@bacherfl
update go.mod
83e1e8a 
Signed-off-by: Florian Bacher <[email protected]>
@thisthat thisthat mentioned this pull request Oct 12, 2022
Merged
@bacherfl bacherfl merged commit 9fd210d into main Oct 12, 2022
@bacherfl bacherfl deleted the feat/scheduler-otel-collector branch October 12, 2022 08:27
@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@thisthat thisthat thisthat approved these changes

@thschue thschue Awaiting requested review from thschue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bacherfl @thisthat @odubajDT