Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): Introduce OTel tracing for Task controller #128

Merged
merged 2 commits into from
Oct 7, 2022
Merged

feat(operator): Introduce OTel tracing for Task controller #128

merged 2 commits into from
Oct 7, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 6, 2022

Signed-off-by: odubajDT [email protected]

@odubajDT
minor fix
e9219fd 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review October 7, 2022 07:58
thisthat
thisthat approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
In the future we might create also a Span that tracks the lifespan of the Job

@odubajDT
Copy link
Contributor Author

odubajDT commented Oct 7, 2022

LGTM. In the future we might create also a Span that tracks the lifespan of the Job

Sure, should I create a follow up ticket for that ?

@thisthat
Copy link
Member

thisthat commented Oct 7, 2022 •
edited
Loading

LGTM. In the future we might create also a Span that tracks the lifespan of the Job

Sure, should I create a follow up ticket for that ?

Let's wait until we have something on a UI :) #132

thschue
thschue approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 0baf7a9 into main Oct 7, 2022
@thschue thschue deleted the feat/trace-task branch October 7, 2022 08:50
@github-actions github-actions bot mentioned this pull request Oct 7, 2022
Merged
@odubajDT odubajDT mentioned this pull request Oct 7, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

@thisthat thisthat thisthat approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odubajDT @thisthat @thschue