Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

fix: invalid syntax in dashboard tile titles should return error #800

Conversation

j-poecher
Copy link
Contributor

closes #630

If a tile title cannot be parsed correctly, the processing of the SLI is aborted and an error result is returned for this SLI.

When does the parsing fail?

  • duplicate keys for sli, weight, key
  • wrong values for
    • sli: empty, white-space only
    • weight: non-integer values
    • key: non-boolean values (everything except 0, 1, true, false, True, False, TRUE, FALSE)
    • pass | warning: basically everything that does not match: "^(<|<=|=|>|>=)([+-]?\\d+|[+-]?\\d+\\.\\d+)([%]?)$"

internal/common/common.go Show resolved Hide resolved
internal/common/common.go Show resolved Hide resolved
internal/common/common.go Outdated Show resolved Hide resolved
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
@j-poecher j-poecher force-pushed the fix/630/invalid-syntax-in-dashboard-tile-titles-should-return-error branch from eb57a7e to 23022af Compare May 9, 2022 12:01
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

The following Docker Images have been built:
keptncontrib/dynatrace-service:0.23.0-dev-PR-800,keptncontrib/dynatrace-service:0.23.0-dev-PR-800.202205091201

Copy link
Collaborator

@arthurpitman arthurpitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-poecher j-poecher merged commit c93c862 into master May 9, 2022
@j-poecher j-poecher deleted the fix/630/invalid-syntax-in-dashboard-tile-titles-should-return-error branch May 9, 2022 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid syntax in dashboard tile titles should produce an error
2 participants