This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
fix: invalid syntax in dashboard tile titles should return error #800
Merged
j-poecher
merged 19 commits into
master
from
fix/630/invalid-syntax-in-dashboard-tile-titles-should-return-error
May 9, 2022
Merged
fix: invalid syntax in dashboard tile titles should return error #800
j-poecher
merged 19 commits into
master
from
fix/630/invalid-syntax-in-dashboard-tile-titles-should-return-error
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-poecher
requested review from
agrimmer,
arthurpitman,
heckelmann,
hubmat00,
jskelin and
Kavindu-Dodan
as code owners
May 6, 2022 16:22
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
j-poecher
force-pushed
the
fix/630/invalid-syntax-in-dashboard-tile-titles-should-return-error
branch
from
May 9, 2022 12:01
eb57a7e
to
23022af
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The following Docker Images have been built: |
arthurpitman
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
j-poecher
deleted the
fix/630/invalid-syntax-in-dashboard-tile-titles-should-return-error
branch
May 9, 2022 12:07
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #630
If a tile title cannot be parsed correctly, the processing of the SLI is aborted and an error result is returned for this SLI.
When does the parsing fail?
sli
,weight
,key
sli
: empty, white-space onlyweight
: non-integer valueskey
: non-boolean values (everything except0
,1
,true
,false
,True
,False
,TRUE
,FALSE
)pass
|warning
: basically everything that does not match:"^(<|<=|=|>|>=)([+-]?\\d+|[+-]?\\d+\\.\\d+)([%]?)$"