Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

fix: Ensure problem notifications created using keptn configure monitoring refer to a valid project #671

Merged
merged 6 commits into from
Jan 12, 2022
Merged

fix: Ensure problem notifications created using keptn configure monitoring refer to a valid project #671

merged 6 commits into from
Jan 12, 2022

Conversation

arthurpitman
Copy link
Collaborator

Closes #668

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

The following Docker Images have been built:

  • Pushed keptncontrib/dynatrace-service:0.20.0-dev-PR-671.202201121444 and keptncontrib/dynatrace-service:0.20.0-dev-PR-671 (Source: ./)

j-poecher
j-poecher approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurpitman arthurpitman changed the title fix: Ensure problem notifications created using keptn configure monitoring refer to a valid project #668 fix: Ensure problem notifications created using keptn configure monitoring refer to a valid project Jan 12, 2022
@arthurpitman arthurpitman merged commit fc9bdc5 into master Jan 12, 2022
@arthurpitman arthurpitman deleted the fix/668/ensure-project-in-keptn-notification branch January 12, 2022 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-poecher j-poecher j-poecher approved these changes

@agrimmer agrimmer Awaiting requested review from agrimmer agrimmer is a code owner

@heckelmann heckelmann Awaiting requested review from heckelmann

@jskelin jskelin Awaiting requested review from jskelin

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure problem notifications refer to a valid Keptn project
2 participants
@arthurpitman @j-poecher