This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
feat!: Require dynatrace.conf.yaml and remove default configuration
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
Signed-off-by: Arthur Pitman <[email protected]>
arthurpitman
changed the title
dynatrace.conf.yaml and remove default configuration #592dynatrace.conf.yaml and remove default configuration
|
Kudos, SonarCloud Quality Gate passed!
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| //go:generate moq --skip-ensure -pkg adapter_mock -out ./mock/dynatrace_config_mock.go . DynatraceConfigGetterInterface | ||
| type DynatraceConfigGetterInterface interface { | ||
| GetDynatraceConfig(event adapter.EventContentAdapter) (*DynatraceConfigFile, error) | ||
| //go:generate moq --skip-ensure -pkg adapter_mock -out ./mock/dynatrace_config_mock.go . DynatraceConfigProvider |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
comment on exported type DynatraceConfigProvider should be of the form "DynatraceConfigProvider ..." (with optional leading article)
|
The following Docker Images have been built:
|
arthurpitman
requested review from
agrimmer,
heckelmann,
jskelin and
Kavindu-Dodan
as code owners
arthurpitman
changed the title
dynatrace.conf.yaml and remove default configurationdynatrace.conf.yaml and remove default configuration
arthurpitman
deleted the
patch/592/remove-fallback-to-default-configuration
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #592