Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

fix: Custom Charting and Data Explorer dashboard tiles that return no data should produce a failed indicator value and be included in SLO objectives #610

Merged
merged 3 commits into from
Nov 24, 2021
Merged

fix: Custom Charting and Data Explorer dashboard tiles that return no data should produce a failed indicator value and be included in SLO objectives #610

merged 3 commits into from
Nov 24, 2021

Conversation

arthurpitman
Copy link
Collaborator

Closes #609

@arthurpitman
Add test
ba48e39 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Produce failed tile result for no data
05aebed 
Signed-off-by: Arthur Pitman <[email protected]>
@arthurpitman
Update test
5f14f97 
Signed-off-by: Arthur Pitman <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

The following Docker Images have been built:

  • Pushed keptncontrib/dynatrace-service:0.18.2-dev-PR-610.202111241304 and keptncontrib/dynatrace-service:0.18.2-dev-PR-610 (Source: ./)

j-poecher
j-poecher approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@j-poecher j-poecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurpitman arthurpitman merged commit 8df2f95 into master Nov 24, 2021
@arthurpitman arthurpitman deleted the fix/609/failed-tile-result-for-no-data branch November 24, 2021 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-poecher j-poecher j-poecher approved these changes

@agrimmer agrimmer Awaiting requested review from agrimmer agrimmer is a code owner

@heckelmann heckelmann Awaiting requested review from heckelmann

@jskelin jskelin Awaiting requested review from jskelin

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arthurpitman @j-poecher