Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc changes sample apps - Add 3 apps and change installation.md flow #447

Merged
merged 11 commits into from
Aug 26, 2024

Conversation

TvisharajiK
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

@nehagup nehagup requested a review from Sonichigo August 19, 2024 10:21
@Sonichigo
Copy link
Member

@TvisharajiK Deploy has failed please check once via npm run build locally to test the changes

@TvisharajiK TvisharajiK self-assigned this Aug 19, 2024
@@ -130,17 +132,25 @@ Here we just need to change the command used to start the application.
keploy record -c "docker compose up" --container-name javaApp --build-delay 100
```

<img src="/docs/img/pet-clinic-record.png" alt="Sample Keploy Test Result Node JWT" width="100%" style={{ borderRadius: '5px' }} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt tags needs to be updated here and above too.

```bash
keploy record -c "sudo docker-compose up" --containerName "ts-nhost"
```
<img src="/docs/img/wsl-record-ts.png" alt="Sample Keploy Test Result Node JWT" width="100%" style={{ borderRadius: '5px' }} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt tag value need to be updated


You will be able to see the summary of your test cases run in your terminal!

<!-- ![Test Record](/img/wsl-test-ts.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed if not being used

This is what your response should look like!

<img src="/docs/img/wsl-test-ts.png" alt="Sample Keploy Test TS Nhost" width="100%" style={{ borderRadius: '5px' }} />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two images are together. Please add a one line on how both are different.

## Running the testcases using Keploy

```bash
keploy test -c "docker compose up" --container-name javaApp --build-delay 50 --delay 20
```

<img src="/docs/img/pet-clinic-test1.png" alt="Sample Keploy Test Java" width="100%" style={{ borderRadius: '5px' }} />


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two images are together. Please add a one line on how both are different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey any update on this? This was fixed

@Sonichigo Sonichigo merged commit ca1d810 into keploy:main Aug 26, 2024
2 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
…447)

* Doc V2 - Java Modal Change

* Added Installation with Debian

* added new sample apps and made few existing changes

* checking if works

* added image links

* added image link

* Resolved merge issues

* Resolved merge conflicts again

* Image tags changed for all

---------

Signed-off-by: Animesh Pathak <[email protected]>
Co-authored-by: Tvisha Raji <[email protected]>
Co-authored-by: Neha Gupta <[email protected]>
Co-authored-by: Animesh Pathak <[email protected]>
@TvisharajiK TvisharajiK deleted the doc-changes-sample-apps branch August 26, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants