fixed syntax related to [dir="rtl"] #2691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute selector syntax was incorrect in this file. For example,
would compile to
.slick-next:before[dir="rtl"]
, when what was intended was[dir="rtl"] .slick-next:before
, and this would cause browsers to ignore that rule.I discovered this problem when I minified my compiled stylesheet with clean-css and the Next arrow disappeared: the
<button>
was still there but it had no::before
pseudo element which is where the arrow exists. clean-css grouped the.slick-next:before
rule that defined the arrow with.slick-prev
's broken:before[dir="rtl"]
rule, causing both rules to be ignored:The syntax is correct in
slick-theme.scss
.