Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated version field from bower.json file #2557

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Remove deprecated version field from bower.json file #2557

merged 1 commit into from
Oct 18, 2016

Conversation

wolfika
Copy link
Contributor

@wolfika wolfika commented Oct 10, 2016

refs #2555

@leggomuhgreggo
Copy link
Collaborator

Hey @wolfika never having used bower, I wanted to get a better idea of the landscape in the hopes of heading off any subsequent complications merging this PR might invite. I remembered this discussion #2246 from a while back--doesn't look like it actually bears on this issue, but thought I'd reference it anyhow.

I guess my only remaining concern is how many people might be using on older versions of bower that rely on the version field declaration. Let me know if you have any thoughts on the subject. Definitely leaning towards merging this in.

Thanks

@wolfika
Copy link
Contributor Author

wolfika commented Oct 13, 2016

I would find it rational if Bower used git tags a default fallback for parsing a valid semver version if that could not be done from the bower.json. This is just a speculation, I don't know older Bower releases to that extent, but I would find that logical, some further research required.

@leggomuhgreggo leggomuhgreggo merged commit c74ed21 into kenwheeler:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants