Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch coverage is off somehow. Because of super? #12

Open
im-martijn opened this issue Oct 26, 2016 · 2 comments
Open

Branch coverage is off somehow. Because of super? #12

im-martijn opened this issue Oct 26, 2016 · 2 comments

Comments

@im-martijn
Copy link

Hi,

Great workshop!

I noticed that my test coverage is 100% on almost everything, but not for % Branch in Toggle.js and CustomerList.js. In Toggle.js I get 5/6 branches coverage, in CustomerList.js I get 3/4 branches coverage. I don't hink I did anything wrong, I also get these coverages when I switch to the master branch. It might be the nyc/istanbul version. I see there is an issue that I think is causing this.

How could I go about and fix this in your example files?

Thanks!
Martijn

@kentcdodds
Copy link
Owner

Hi! Actually, I recommend against using AVA these days. It has some serious perf issues. Instead, I recommend you use Jest (I have a jest version of this repo here: https://github.com/kentcdodds/react-jest-workshop). Learn more about Jest here: http://kcd.im/egghead-jest

If you want to try to fix this, I'm happy to accept a pull request. God luck!

@im-martijn
Copy link
Author

im-martijn commented Oct 28, 2016

Thanks! Will have a look at jest right away ;)

It might be good to put an update on the readme.md that indicates your current view against ava and the link to the jest workshop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants