Don't allow simple match to meet acronym threshold #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, this is definitely a bug. Would you be willing to add a commit for the fix? Thanks! |
|
@kentcdodds I'd love to. It may take a few days as I try to figure out the "correct" way to weight simple matches comparatively on a scale. |
sdbrannum
changed the title
|
Thank you! |
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors please add @sdbrannum for code and tests |
|
I've put up a pull request to add @sdbrannum! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added test case for acronym threshold.
Why:
Currently, the base simple match threshold is meeting the standard of the acronym threshold in certain instances.
How:
Checklist: