Fix broken links on table of content #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... The table of contents is generated. If you look at this PR you'll see the diff isn't showing your ToC changes because when you commit, the table is regenerated based on the headings. I'm guessing we'll need to change a heading so it isn't broken. |
|
Looks like the fact that there's a link in the heading is the problem. If you move the link to right below the heading with something like "Learn more" then that would fix it. |
|
Oh... i did not pay attention to the regeneration of that... my bad. I'm going to rework that! |
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix broken markdown on table of contents (link)
Why: Users can go directly to the topic when clicking on the table of content.
How: Updating markdown properly to have a link to the correct location.