Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor away babel-core dependency #43

Closed
kentcdodds opened this issue Oct 30, 2017 · 2 comments
Closed

Refactor away babel-core dependency #43

kentcdodds opened this issue Oct 30, 2017 · 2 comments

Comments

@kentcdodds
Copy link
Owner

Due to kentcdodds/babel-plugin-macros#41 we want to refactor babel-core away from our dependencies:

  1. Remove babel-core from the package.json dependencies.
  2. Remove the require here and instead accept babel as a item in the options argument.
  3. Change this to babel and move the destructuring to a const on the next line.
  4. Pass babel to each use of getReplacement

I think that's it. Anyone wanna do that?

@xjlim
Copy link
Collaborator

xjlim commented Oct 30, 2017

I'd like to work on this.

@kentcdodds
Copy link
Owner Author

Awesome. Thanks @xjlim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants