feat(resolve): add fallback path to be able to resolve modules relatively to babel-plugin-macros
#138
Conversation
…vely to `babel-plugin-macros`
| return resolve.sync(source, {basedir}) | ||
| return resolve.sync(source, { | ||
| basedir, | ||
| paths: [p.resolve(__dirname, '../../')] |
There was a problem hiding this comment.
Should we include process.cwd() in this as well?
There was a problem hiding this comment.
No, because it is a fallback only. If it cannot resolve relatively to basedir using node's built in resolve mechanism, then it tries with the provided paths as well (in the fallback case there is no travesing up to the parent, that's why ../../ is necessary).
I was using with process.cwd() included tho, but removing it didn't cause any issues. That case can only happen if plugin is installed outside of cwd and basedir is also not with-in cwd, which is highly unlikely imo. Should I add it just for safety?
There was a problem hiding this comment.
My use case is that I have my devtools globally installed, so at project level I basically don't have any node_modules folder. This means babel-plugin-macros also being installed globally.
There was a problem hiding this comment.
That's pretty odd. But as this doesn't break anything I'm fine with it.
|
@all-contributors please add @wintercounter for code |
|
I've put up a pull request to add @wintercounter! 🎉 |
|
Any ETA on the release? |
|
Sorry, there appears to be a problem with the build/release. Will try to resolve as soon as possible. |
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: #87
Why: In case you have
babel-plugin-macrosloaded outside ofprocess.cwd()it cannot resolve modules realtively to itself.How: Added the node_modules folder including
babel-plugin-macrosas a fallback path.