Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(frontend): pin dependencies #555

Merged
merged 3 commits into from
May 17, 2020
Merged

build(frontend): pin dependencies #555

merged 3 commits into from
May 17, 2020

Conversation

reminjp
Copy link
Contributor

@reminjp reminjp commented May 17, 2020

close #554

Issue本文の通り。

@reminjp
Copy link
Contributor Author

reminjp commented May 17, 2020

CIさんfailedしているけれど……

@reminjp
Copy link
Contributor Author

reminjp commented May 17, 2020

エラーが見当違いに見えたので調べたところ、require-atomic-updatesルールがeslint:recommendedに入ったものの不具合があるらしいです。バージョンによってエラーを吐いたり吐かなかったりしているのだと見受けられます。無効にするのが妥当でしょうか……

cf. eslint/eslint#11899

@reminjp
Copy link
Contributor Author

reminjp commented May 17, 2020

冷静に考えると↑は別PRで出すべきでしたが……

@kenkoooo kenkoooo merged commit 47afa80 into kenkoooo:master May 17, 2020
@reminjp reminjp deleted the 554-pin-dependencies branch May 17, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build(frontend): pin dependencies
2 participants
@reminjp @kenkoooo