fix(sanity): makes the name search for getPlayer(s) case insensitive

this resolves a bug where an attempt to make it case insensitive made this line fail and the function returned null as a result
KenEucker · Jan 24, 2024 · 149d93a · 149d93a
1 parent bbd3442
commit 149d93a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/examples/node/index.js b/examples/node/index.js
@@ -130,8 +130,8 @@ const getAllGamesAsync = async (pre, client, out = false, opts = {}) => {
 
 const get1PlayerAsync = async (pre, client, out = false, opts = {}) => {
   opts.limit = opts.limit ? opts.limit : 10
-  const name = 'Ken'
-  const testPlayerData = await client.getPlayer(name, opts).catch(console.error)
+  const name = 'KalihiKlipless'
+  const testPlayerData = await client.getPlayer({name}, opts).catch(console.error)
   log(`${pre} :: success fully retrieved player data for [${name}]`, testPlayerData, out)
 
   return testPlayerData
@@ -210,8 +210,8 @@ const runTests = async (out = false) => {
     await getGameAsync("Sanity", bikeTagSanityInstance, out)
     // await getAllGamesAsync("Sanity", bikeTagSanityInstance, out)
     // await get10PlayersAsync("Sanity", bikeTagSanityInstance, out)
-    // await get1PlayerAsync("Sanity", bikeTagSanityInstance, out)
-    await get10AchievementsAsync("Sanity", bikeTagSanityInstance, out)
+    await get1PlayerAsync("Sanity", bikeTagSanityInstance, out)
+    // await get10AchievementsAsync("Sanity", bikeTagSanityInstance, out)
     // await get10AmbassadorsAsync("Sanity", bikeTagSanityInstance, out)
     // await get10SettingsAsync("Sanity", bikeTagSanityInstance, out)
     // await get10AchievementsAsync("Sanity", bikeTagSanityInstance, out)

diff --git a/src/sanity/getPlayers.ts b/src/sanity/getPlayers.ts
@@ -42,7 +42,7 @@ export async function getPlayers(
       playersData = playersData.filter((p) => payload.slugs?.includes(p.slug))
     } else if (payload.names?.length) {
       playersData = playersData.filter((p) =>
-        payload.names?.includes(p.name.toLowerCase())
+        payload.names?.find((n) => n.toLowerCase() === p.name.toLowerCase())
       )
     }
 

diff --git a/src/sanity/helpers.ts b/src/sanity/helpers.ts
@@ -438,10 +438,10 @@ export function constructSanityDocumentQuery(
   append = ''
 ): any {
   const gameQuery = game
-    ? ` && ((game._ref in *[_type=="game" && lower(name)=="${game.toLowerCase()}"]._id) || (count(*[ _type == "game" && lower(name) =="${game.toLowerCase()}" && ^._id in ${docType}s[]._ref ]) > 0))`
+    ? ` && ((lower(name) =="${game.toLowerCase()}") || (game._ref in *[_type=="game" && lower(name)=="${game.toLowerCase()}"]._id) || (count(*[ _type == "game" && lower(name) =="${game.toLowerCase()}" && ^._id in ${docType}s[]._ref ]) > 0))`
     : ''
   const playerQuery = player
-    ? ` && ((player._ref in *[_type=="player" && lower(name)=="${player.toLowerCase()}"]._id) || (count(*[ _type == "player" && lower(name) =="${player.toLowerCase()}" && ^._id in ${docType}s[]._ref ]) > 0))`
+    ? ` && ((lower(name) =="${player.toLowerCase()}") || (player._ref in *[_type=="player" && lower(name)=="${player.toLowerCase()}"]._id) || (count(*[ _type == "player" && lower(name) =="${player.toLowerCase()}" && ^._id in ${docType}s[]._ref ]) > 0))`
     : ''
   const slugsQuery = slugs.length
     ? ` && slug.current in ${JSON.stringify(slugs)}`