Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 16 #377

Open
lukestanley opened this issue Jul 31, 2023 · 2 comments
Open

Angular 16 #377

lukestanley opened this issue Jul 31, 2023 · 2 comments
Assignees

Comments

@lukestanley
Copy link
Member

lukestanley commented Jul 31, 2023

I extracted a list of dependent app pages from compile failure:

With the error log by path frequency, the NPM modules for: formly, followed by mermaid, leaflet were top.
For our own code src/app/pages/form-builder-page/form-builder-page.component.ts had the most issues, understandably if it's not loaded properly.
Followed by our graphql block:
src/app/components/block-graphql-builder-box/block-graphql-builder-box.component.ts
Then kql-builder page which I'm not familiar with:
src/app/pages/kql-builder/kql-builder.component.ts

Here is a rationale for how we might decide what to do:
If needed, we might temporarily remove some functionality to make progress with upgrading to Angular 16 if it is minor.
Otherwise if it too complex, we might pause work on the upgrade.

@lukestanley lukestanley self-assigned this Jul 31, 2023
@JaimieBlack
Copy link

I'll take this on, might need something with write or admin access to assign this to me though :)

@gsambrotta
Copy link
Collaborator

PR #425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants