Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eisop fork without warnings #279

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Support eisop fork without warnings #279

merged 3 commits into from
Jun 26, 2024

Conversation

kelloggm
Copy link
Owner

Correctly handles version-checking for any Checker Framework fork whose version string starts with a version string from the main Checker Framework repository.

I tested that with the instructions in #277 this no longer leads to a printout about using the default Checker Framework version when using the EISOP fork. So, this closes out #275 completely.

@kelloggm kelloggm requested a review from mernst June 25, 2024 15:12
Copy link
Collaborator

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wmdietl
Copy link
Collaborator

wmdietl commented Jun 26, 2024

Thanks for this improvement!

@kelloggm kelloggm merged commit e2a7de6 into master Jun 26, 2024
4 checks passed
@kelloggm kelloggm deleted the eisop-no-warn branch June 26, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants