Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support iojs 3.0.0 #322

Closed
jbergstroem opened this issue Aug 5, 2015 · 6 comments
Closed

Support iojs 3.0.0 #322

jbergstroem opened this issue Aug 5, 2015 · 6 comments

Comments

@jbergstroem
Copy link

Breaks while compiling -- tried upgrading to nan 2.0.0. There is some api changes forcing a refactor. If no one else has time I can have a look at this in a week.

@haoxins
Copy link

haoxins commented Aug 5, 2015

waiting for this issue to be fixed? nodejs/nan#389

@defunctzombie
Copy link
Collaborator

Good to know about that one. Certainly will give these projects some time to bake. I understand folks want to test and upgrade quickly but some of the API changes will take a refactor. Without a migration guide for NaN 1.x to 2.x it will be slower going.

@nicolasgramlich
Copy link

They just fixed it: nodejs/nan#389 (comment) the commit he referenced is part of the 2.0.5 tag: nodejs/nan@98d38c1

@jbergstroem
Copy link
Author

@defunctzombie nan async pi works as a pretty good example for porting/implementing nan 2.0.0+.

Edit: Also, here's node-ffi's effort.

@defunctzombie
Copy link
Collaborator

PR here: #324

Everyone who is interested please test this out and report issues.

@defunctzombie
Copy link
Collaborator

Released in 0.8.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants