Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of Croppy #38

Open
kekland opened this issue Jul 18, 2024 · 1 comment
Open

State of Croppy #38

kekland opened this issue Jul 18, 2024 · 1 comment

Comments

@kekland
Copy link
Owner

kekland commented Jul 18, 2024

Hi guys!

Unfortunately at the moment I'm extremely busy with work projects. I don't have enough time to check on issues/pull requests. I've however noticed that there's quite a lot of activity around the package, which I didn't initially expect :P

Very sorry for that. At the moment I don't have an exact timeline as to when I'll be able to work on the package. The reason as to why I can't commit hours working on this is that this package was developed as a part of our application, and currently it perfectly fits our usecase.

Many thanks to all the people who're submitting pull requests - I'll try to look through those and merge them on July 20. As for other issues - no estimate yet.

In the future I have a refactor planned for this package as well as a couple of big new features (video support?)

Special thanks to @talamaska who's been active in helping out other people with this package from the beginning.

@kekland kekland pinned this issue Jul 18, 2024
@kekland
Copy link
Owner Author

kekland commented Jul 20, 2024

Thanks everyone for the pull requests! I've merged all of them and deployed version 1.2.0 with a couple of more fixes. Also note that 1.2.0 has a minimum Flutter constraint of 3.22.0 due to WASM support. However, if this is breaking things for lots of people, I can deploy another version with a lesser Flutter constraint.

As for the prevalent theme issue - I've added a temporary solution that allows you to pass ThemeData/CupertinoThemeData when pushing the cropper. I've fixed the theme auto-generation, so now it should properly respect the incoming primary color and generate the appropriate theme.

If the auto-generated theme still looks off, you can pass a custom Theme like so:

final result = await showMaterialImageCropper(
  context,
  imageProvider: const NetworkImage('MY_IMAGE_URL'), // Or any other image provider
  themeData: ThemeData(...),
);

final result = await showCupertinoImageCropper(
  context,
  imageProvider: const NetworkImage('MY_IMAGE_URL'), // Or any other image provider
  themeData: CupertinoThemeData(...),
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant