Add hanmanwuzhe source #5099
Merged
Add hanmanwuzhe source #5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anenasa
reviewed
Sep 18, 2024
| return GET(page.imageUrl!!, newHeaders) | ||
| } | ||
|
|
||
| private class Genre(name: String, val id: String = name) : Filter.CheckBox(name) |
There was a problem hiding this comment.
I have a question, why use CheckBox if only one genre can be chosen?
There was a problem hiding this comment.
I don't really know the functions, sorry 😅, is there a function for a radio button?
There was a problem hiding this comment.
You can use Filter.Select to create drop-down list.
|
This site is MCCMS, I'll review later. |
|
are there any updates for this? @stevenyomi |
|
@heagan01 you should move this to MCCMS multisrc as steven pointed out |
|
I've done it, are there any changes needed? |
AwkwardPeak7
reviewed
Nov 4, 2024
Comment on lines
17
to
19
| // Details and chapter pages are broken | ||
| override fun getMangaUrl(manga: SManga) = baseUrl | ||
| override fun getChapterUrl(chapter: SChapter) = baseUrl |
There was a problem hiding this comment.
broken how? I just tested and should work fine
There was a problem hiding this comment.
i copy pasted the code from other extension (DidaManhua)
AwkwardPeak7
reviewed
Nov 7, 2024
src/zh/hanmanwuzhe/src/eu/kanade/tachiyomi/extension/zh/hanmanwuzhe/hanmanwuzhe.kt
Outdated
Show resolved
Hide resolved
src/zh/hanmanwuzhe/src/eu/kanade/tachiyomi/extension/zh/hanmanwuzhe/hanmanwuzhe.kt
Outdated
Show resolved
Hide resolved
AwkwardPeak7
approved these changes
Nov 7, 2024
stevenyomi
added a commit
that referenced
this pull request
Nov 7, 2024
This reverts commit adc6d00.
stevenyomi
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5086
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension