You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this a BUG REPORT or FEATURE REQUEST?:
Bug What happened:
If user configured MaxUnavailable, then keiko uses it as a batch for rollout. I.e. if it is set to 5, then keiko will create batches of size 5 and roll them one after another. What you expected to happen:
Keiko should always try to roll MaxUnavailable nodes - treat MaxUnavailable as number of nodes to be rolled out at all times.
How to reproduce it (as minimally and precisely as possible):
The downside of the implementation is that single node may delay up to 1h rollout.
Other info: we have some groups that have >150 nodes, rollout takes very long time because of this issue and #140
Also, happy to submit PR once we agree on a proper fix.
The text was updated successfully, but these errors were encountered:
uthark
changed the title
MaxUnavailable works as a batch, not as a percentage.
MaxUnavailable works as a batch size, not as a rate
Nov 14, 2020
Is this a BUG REPORT or FEATURE REQUEST?:
Bug
What happened:
If user configured MaxUnavailable, then keiko uses it as a batch for rollout. I.e. if it is set to 5, then keiko will create batches of size 5 and roll them one after another.
What you expected to happen:
Keiko should always try to roll
MaxUnavailable
nodes - treat MaxUnavailable as number of nodes to be rolled out at all times.How to reproduce it (as minimally and precisely as possible):
The downside of the implementation is that single node may delay up to 1h rollout.
Relevant code: https://github.com/keikoproj/upgrade-manager/blob/master/controllers/rollingupgrade_controller.go#L477-L481
New instances are selected only after current batch finishes.
Other info: we have some groups that have >150 nodes, rollout takes very long time because of this issue and #140
Also, happy to submit PR once we agree on a proper fix.
The text was updated successfully, but these errors were encountered: