Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create worker subdirectory for worker docker image #3

Open
tekenstam opened this issue Aug 15, 2019 · 4 comments · May be fixed by #15
Open

Create worker subdirectory for worker docker image #3

tekenstam opened this issue Aug 15, 2019 · 4 comments · May be fixed by #15
Labels

Comments

@tekenstam
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE

What happened: Currently there are multiple docker files in the root of the repo. This may be confusing for which docker file creates which image.

What you expected to happen:

  1. Create new worker subdir
    • Move Dockerfile.worker and script for the worker image to this directory
  2. Move Dockerfile to the controllers subdirectory
  3. Update Makefile to reflect these changes
@z0rx0r
Copy link

z0rx0r commented Sep 28, 2019

I'll take this.

@z0rx0r
Copy link

z0rx0r commented Oct 1, 2019

➜ kube-forensics git:(feature/docker-subdir) git push origin feature/docker-subdir
ERROR: Permission to keikoproj/kube-forensics.git denied to z0rx0r.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@tekenstam
Copy link
Member Author

@z0rx0r Please fork this repo and submit your PR per our contribution guidelines.

https://github.com/keikoproj/kube-forensics/blob/master/.github/CONTRIBUTING.md

@AnShafs
Copy link

AnShafs commented Oct 9, 2019

Sorry, I had to delete PR #14. It was committed with the wrong name and I couldn't pass the cla check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants