ResolveSubnets/ResolveSecurityGroups may cause infinite reconcile

[eytan-avisror]

We should add sorting to the slice so that we don't end up constantly reconciling because the list is changing.

instance-manager/controllers/provisioners/eks/helpers.go

Lines 43 to 70 in d5df858

	func (ctx *EksInstanceGroupContext) ResolveSubnets() []string {
	var (
	instanceGroup = ctx.GetInstanceGroup()
	configuration = instanceGroup.GetEKSConfiguration()
	state = ctx.GetDiscoveredState()
	resolved = make([]string, 0)
	)
	for _, s := range configuration.GetSubnets() {
	if strings.HasPrefix(s, "subnet-") {
	resolved = append(resolved, s)
	continue
	}
	sn, err := ctx.AwsWorker.SubnetByName(s, state.GetVPCId())
	if err != nil {
	ctx.Log.Error(err, "failed to resolve subnet id by name", "subnet", s)
	continue
	}
	if sn == nil {
	ctx.Log.Error(errors.New("subnet not found"), "failed to resolve subnet by name", "subnet", s)
	continue
	}
	resolved = append(resolved, aws.StringValue(sn.SubnetId))
	}
	return resolved
	}

Same thing for resolve security groups by name:

instance-manager/controllers/provisioners/eks/helpers.go

Lines 72 to 99 in 503d90c

	func (ctx *EksInstanceGroupContext) ResolveSecurityGroups() []string {
	var (
	instanceGroup = ctx.GetInstanceGroup()
	configuration = instanceGroup.GetEKSConfiguration()
	state = ctx.GetDiscoveredState()
	resolved = make([]string, 0)
	)
	for _, g := range configuration.GetSecurityGroups() {
	if strings.HasPrefix(g, "sg-") {
	resolved = append(resolved, g)
	continue
	}
	sg, err := ctx.AwsWorker.SecurityGroupByName(g, state.GetVPCId())
	if err != nil {
	ctx.Log.Error(err, "failed to resolve security group by name", "security-group", g)
	continue
	}
	if sg == nil {
	ctx.Log.Error(errors.New("security group not found"), "failed to resolve security group by name", "security-group", g)
	continue
	}
	resolved = append(resolved, aws.StringValue(sg.GroupId))
	}
	return resolved
	}