crd strategy - reconcile may complete before resource is completed

[eytan-avisror]

Looks like there is a code path where we can mark reconcile successful prematurely during an upgrade.

According to the following snippet:

instance-manager/controllers/provisioners/eks/update.go

Lines 107 to 115 in d84908b

	// update readiness conditions
	nodesReady := ctx.UpdateNodeReadyCondition()
	if nodesReady {
	instanceGroup.SetState(v1alpha1.ReconcileModified)
	}
	if rotationNeeded {
	instanceGroup.SetState(v1alpha1.ReconcileInitUpgrade)
	}

It seems we don't enter the upgrade path nodes are ready and rotationNeeded is not true - In this case it can happen when the last node is rotated (as now rotationNeeded is false), however, the upgrade resource object is still running.

rotationNeeded should also check if the status.strategyResourceName resource is still active.