Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings when compiling with >=2.5.0 #269

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

delaaxe
Copy link
Contributor

@delaaxe delaaxe commented Jan 31, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@delaaxe delaaxe requested a review from 0xLucqs as a code owner January 31, 2024 09:27
@delaaxe delaaxe changed the title Fix warning when compiling under 2.5.0 Fix warning when compiling under >=2.5.0 Jan 31, 2024
@delaaxe delaaxe changed the title Fix warning when compiling under >=2.5.0 Fix warning when compiling with >=2.5.0 Jan 31, 2024
@delaaxe delaaxe changed the title Fix warning when compiling with >=2.5.0 Fix warnings when compiling with >=2.5.0 Jan 31, 2024
@0xLucqs
Copy link
Collaborator

0xLucqs commented Jan 31, 2024

Do you think you can do the full migration to v2.5.0?

@delaaxe
Copy link
Contributor Author

delaaxe commented Jan 31, 2024

Sure, it already works on 2.5.0, I assume you mean upgrade to use the new features? I'd merge this first so other projects can start using right away though

@0xLucqs 0xLucqs merged commit 39d20fb into keep-starknet-strange:main Jan 31, 2024
3 checks passed
@delaaxe
Copy link
Contributor Author

delaaxe commented Feb 1, 2024

Started the migration in other PRs

@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants