Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wad_ray_math with tests #215

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

FabienCoutant
Copy link
Contributor

@FabienCoutant FabienCoutant commented Nov 13, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Handle Wad & Ray mul/div

Issue Number: #211

What is the new behavior?

Add new functions to handle 18 & 27 decimals base maths

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@gaetbout gaetbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM 👍

src/math/src/tests/wad_ray_math_test.cairo Outdated Show resolved Hide resolved
src/math/src/wad_ray_math.cairo Outdated Show resolved Hide resolved
@0xLucqs 0xLucqs merged commit d32162a into keep-starknet-strange:main Nov 15, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants