Feat: Add solidity like bytes which supports keccak and sha256 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR this looks extreeeemely useful |
|
@LucasLvy Thanks for your review. I have fixed the problems above. |
0xLucqs
requested changes
Oct 6, 2023
|
@LucasLvy Sorry for the codes likes |
0xLucqs
approved these changes
Oct 10, 2023
|
Note that this will be redundant with bytes 31 at some point |
|
hey @zkcarter can you register on https://app.onlydust.xyz/ so i can pay for your contribution ? (can you also tell me how many hours/days you spent on this pr plz) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
bytesis an implementation similar to Solidity bytes written in Cairo 1.It is notable for its built-in implementation of
KeccakandSha256hash functions, offering convenience for migrating EVM Contracts written in Solidity to the Starknet ecosystem.Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
The implementation of
bytesdiffers frombyte_arrayin corelib. Each bytes array element stores 16 bytes and is designed to calculate byte stream hashes more quickly by trading more space for less computational cost.