feat(storage): v2.1.0 improvements #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milancermak
force-pushed
the
feat/list-v2.1.0
branch
from
f3963e3
to
acbf97b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional improvements to
Listimplementation.Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Removing the custom
StorageSizetrait. It's replaced byStore::sizesince in v2.1.0 it doesn't require an arg anymore.Using Poseidon hash instead of Pedersen (LegacyHash) since it's 10x cheaper.
Does this introduce a breaking change?
No easy migration path but I'm guessing no one's using it in prod yet. Since it's a breaking change, I did bump the package version to
0.2.0.Other information
Also shortening the
test_append_get_manytest to go over less elements, should be about half as long while still testing the right behavior.