Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all the .gitignore files in the templates and the starters #3653

Closed
ankatiyar opened this issue Feb 26, 2024 Discussed in #3635 · 4 comments
Closed

Review all the .gitignore files in the templates and the starters #3653

ankatiyar opened this issue Feb 26, 2024 Discussed in #3635 · 4 comments
Assignees

Comments

@ankatiyar
Copy link
Contributor

Discussed in #3635

Originally posted by grofte February 20, 2024
If I make a new Kedro project the lines

# keep also the example dataset
!data/01_raw/*

are in .gitignore file. At the same time you have written in the README that users should not delete any of the lines you have added to .gitignore. I feel like this is going to hurt a lot of newbies that accidentally add a big dataset to git and then struggle to get rid of it. Even for the example with spaceflights I think it's a terrible idea to add the data to git.

PS I have not installed the example.

PPS I could not find it in your codebase or I would have written a PR. At the same time it's not a bug, just a terrible choice.

@ankatiyar
Copy link
Contributor Author

@noklam #3635 (reply in thread)

@ankatiyar ankatiyar changed the title !data/01_raw/* should not be in the default .gitignore Review all the .gitignore files in the templates and the starters Feb 26, 2024
@noklam
Copy link
Contributor

noklam commented Feb 26, 2024

@Galileo-Galilei
Copy link
Member

Galileo-Galilei commented Oct 28, 2024

While we're at it, we should check for the mlruns/ folder of mlflow. I think the project template has been updated, but not the starters: #3765

@ankatiyar
Copy link
Contributor Author

Completed in #4302 & kedro-org/kedro-starters#250

@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants