-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review all the .gitignore
files in the templates and the starters
#3653
Comments
ankatiyar
changed the title
!data/01_raw/* should not be in the default .gitignore
Review all the Feb 26, 2024
.gitignore
files in the templates and the starters
Line 15 doesn't seem necessasary, can we also review if it's actually needed. |
While we're at it, we should check for the |
This was referenced Nov 6, 2024
Completed in #4302 & kedro-org/kedro-starters#250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #3635
Originally posted by grofte February 20, 2024
If I make a new Kedro project the lines
are in .gitignore file. At the same time you have written in the README that users should not delete any of the lines you have added to .gitignore. I feel like this is going to hurt a lot of newbies that accidentally add a big dataset to git and then struggle to get rid of it. Even for the example with spaceflights I think it's a terrible idea to add the data to git.
PS I have not installed the example.
PPS I could not find it in your codebase or I would have written a PR. At the same time it's not a bug, just a terrible choice.
The text was updated successfully, but these errors were encountered: