-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OmegaConfigLoader requires consistent config for each env #2704
Comments
Hi @KrzysztofDobosz, thanks for opening this issue. Could you share a YAML snippet of what do you mean by:
|
Hi @astrojuanlu. Sure. I have something very similar in the config files:
base/catalog.yml
local/catalog_globals.yml is empty
Unless I copy Actually, while trying to reproduce mentioned error, I noticed that if I define template values in
In my project SQL queries are identical in all envs, but some other template variables aren't. Can I use them somehow with OmegaConfigLoader? |
Thanks for reporting this @KrzysztofDobosz! I've been able to reproduce it. Working on a fix. |
Hey @KrzysztofDobosz, turns out this is expected behaviour for now. We're still working on adding globals functionality for |
Description
OmegaConfigLoader checks for completeness config for each env before updating base config with values from local. This prevents defining global values for data catalog in base config only.
Context
I was trying to use templating with Omega in v 0.18.10. I have sql queries which form spark.SparkJDBCDataSet in base and pandas.SQLQueryDataSet in local. My goal was to be able to define the query just in one place (conf/base/catalog_globals.yml).
Steps to Reproduce
Expected Result
Config from base is updated with values from local, and then templated values are resolved.
Actual Result
This exception is thrown, unless I define globals also in local env (which I was trying to avoid).
Your Environment
pip show kedro
orkedro -V
): 0.18.10python -V
): 3.9The text was updated successfully, but these errors were encountered: