Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse LSP server from Kedro Extension for "go To Definition" and "Go to reference" action from Webview. #2024

Closed
1 task
Tracked by #58 ...
jitu5 opened this issue Aug 2, 2024 · 1 comment

Comments

@jitu5
Copy link
Contributor

jitu5 commented Aug 2, 2024

Description

Currently, the "Go To Definition" and "Go to Reference" features are not fully integrated with the Kedro extension. To enhance the development experience and increase productivity, we propose reusing the Language Server Protocol (LSP) from the Kedro extension for these actions.

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

We aim to create specific VS Code commands that handle "Go To Definition" and "Go to Reference" actions. These commands will interface with the underlying LSP implementation in the Kedro extension.

  • Command Creation:

    • Create two VS Code commands:
      • kedro: Go to definition
      • kedro: Go to reference
    • These commands will accept parameters (e.g., a string representing the target entity).
  • Command Workflow:

  • Request Flow: When a visual component is clicked, it will trigger the corresponding VS Code command.

    • Request Path: React (Frontend) -> VS Code Command -> LSP Client -> LSP
  • Response Flow: The LSP will process the request and return the appropriate response.

    • Response Path: LSP -> VS Code Client

This issue is linked to parent ticket #1968

Checklist

  • Include labels so that we can categorise your feature request
@jitu5 jitu5 added this to Kedro-Viz Aug 2, 2024
@jitu5 jitu5 moved this to Backlog in Kedro-Viz Aug 2, 2024
@jitu5 jitu5 changed the title Reuse LSP from Kedro Extension for "go To Definition" and "Go to reference" action from Webview. Reuse LSP server from Kedro Extension for "go To Definition" and "Go to reference" action from Webview. Aug 2, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Aug 5, 2024
@rashidakanchwala rashidakanchwala moved this from Todo to In Review in Kedro-Viz Aug 19, 2024
@noklam
Copy link
Contributor

noklam commented Aug 28, 2024

Completed in kedro-org/vscode-kedro#56

@noklam noklam closed this as completed Aug 28, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants