Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React18 #1629

Closed
1 task done
rashidakanchwala opened this issue Nov 8, 2023 · 3 comments
Closed
1 task done

Upgrade to React18 #1629

rashidakanchwala opened this issue Nov 8, 2023 · 3 comments
Assignees
@MehdiNV @jitu5
Labels
Issue: Feature Request Javascript Pull requests that update Javascript code

Comments

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Nov 8, 2023 •
edited by NeroOkwa
Loading

Description

Upgrade Kedro-viz to work with React 18.

Context

A reason to prioritise this is because Brix is on React 18 and it can no longer integrate Kedro-viz.

Possible Implementation

(Optional) Suggest an idea for implementing the addition or change.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

Checklist

  • Include labels so that we can categorise your feature request
@rashidakanchwala rashidakanchwala added Issue: Feature Request Javascript Pull requests that update Javascript code labels Nov 8, 2023
@tynandebold tynandebold moved this to Inbox in Kedro-Viz Nov 13, 2023
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Nov 13, 2023
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Nov 13, 2023
@jitu5 jitu5 moved this from Todo to In Progress in Kedro-Viz Nov 13, 2023
@MehdiNV
Copy link
Contributor

MehdiNV commented Nov 14, 2023 •
edited
Loading

Few resources found so far:

Upgrade Guide from the React team: https://react.dev/blog/2022/03/08/react-18-upgrade-guide
Guidance / advice to use React's new Root API: https://www.w3schools.com/react/react_upgrade.asp

@MehdiNV
Copy link
Contributor

MehdiNV commented Nov 15, 2023 •
edited
Loading

Notes

Problematic dependencies

  • React-test-renderer
  • React-json-viewer
  • enzyme-adapter-react (Mehdi; looking into this and seeing how it affects cypress)

Next steps
Migrate to React 18, and replace the 2 breaking tests related to enzyme-adapter-react

@MehdiNV MehdiNV moved this from In Progress to In Review in Kedro-Viz Nov 22, 2023
@rashidakanchwala rashidakanchwala moved this from In Review to Done in Kedro-Viz Dec 13, 2023
@astrojuanlu
Copy link
Member

Is there a follow-up issue for react-scripts? #1652 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MehdiNV MehdiNV

@jitu5 jitu5

Labels
Issue: Feature Request Javascript Pull requests that update Javascript code
Projects
Kedro-Viz
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@astrojuanlu @MehdiNV @rashidakanchwala @jitu5