Can the editable install come with package data? i.e. pip install -e .

[noklam]

Description

Currently, when kedro-viz is installed locally, the assets such as html and css are missing. The contribution guide say that you need to run make build.

This requires the user has npm and make it harder to contribute particularly if one is interested in the Python bit but not the front-end.

Is is possible to make it work without a separate build step? Cc @astrojuanlu

I found some links in setuptools:

• Manifest.in - https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html#controlling-files-in-the-distribution
• https://setuptools.pypa.io/en/latest/userguide/datafiles.html

Checklist

• Include labels so that we can categorise your feature request

[astrojuanlu]

Yes it can be done: #1267 (comment)

[ravi-kumar-pilla]

@astrojuanlu Thank you for the comment. Kedro Viz sdist already contains the js build. But, this ticket is to include js build in local development I guess. We do not have our js build on Git and if someone wants to contribute only python code still needs the js build as the html folder is missing from the version control.

I do not see how the Manifest.in or the datafiles link you shared might help this usecase @noklam , as they are helpful in including the files which are already in the source tree. Please correct me if I am wrong.

To resolve this issue, we need to somehow include the html folder (js build) in the source tree (VCS), so that users can get the files for local development. Happy to hear any other way to do this. Thank you

[rashidakanchwala]

Closing this issue as it cannot be done

[rashidakanchwala]

@astrojuanlu - Requested to reopen this issue. Maybe we can invite you to our next backlog grooming and u can give us more information on this and #1267

[astrojuanlu]

Now that the codebase has been migrated to Node.js 18 #1652 this should be easier to do.

[astrojuanlu]

Explanation (and fix) of #1267 in #1766

[antonymilne]

This is something I've always wanted to have! So +💯 from me if it can be done 😁