Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize all checkRepliacas code and fix the problem does not take effect #6344

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ctccxxd
Copy link

@ctccxxd ctccxxd commented Nov 19, 2024

fix and optimize all checkReplicas code, originally
1, Webhook for replicas check does not take effect.
2, No check for negative value.
3, Variable max or min is same with build-in function name, not graceful
4, Have no defaultMaxReplicas for hpa.
5, Code has redundency.

Checklist

related issue
#6356

@ctccxxd ctccxxd requested a review from a team as a code owner November 19, 2024 03:13
Signed-off-by: Shane <[email protected]>
@ctccxxd ctccxxd marked this pull request as draft November 19, 2024 04:35
@ctccxxd ctccxxd marked this pull request as ready for review November 19, 2024 05:31
@ctccxxd ctccxxd changed the title fix and optimize all checkRepliacas code optimize all checkRepliacas code and fix some Nov 19, 2024
@ctccxxd ctccxxd changed the title optimize all checkRepliacas code and fix some optimize all checkRepliacas code and fix the problem does not take effect Nov 19, 2024
@ctccxxd ctccxxd changed the title optimize all checkRepliacas code and fix the problem does not take effect fix: optimize all checkRepliacas code and fix the problem does not take effect Nov 21, 2024
@ctccxxd
Copy link
Author

ctccxxd commented Nov 21, 2024

Friendly ping @zroubalik @wozniakjan @SpiritZhou @psi @wonko @fivesheep @JorTurFer hope you to review and discuss, much thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant