Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD & sample CR manifest data for downstream OLM operator incomplete #5920

Closed
joelsmith opened this issue Jun 27, 2024 · 0 comments · Fixed by #5921
Closed

CRD & sample CR manifest data for downstream OLM operator incomplete #5920

joelsmith opened this issue Jun 27, 2024 · 0 comments · Fixed by #5921
Labels
bug Something isn't working

Comments

@joelsmith
Copy link
Contributor

Report

While working on the KEDA OLM operator, I noticed the following 3 issues:

  • CRD config/crd/bases/keda.sh_clustertriggerauthentications.yaml does not have a sample CR config/samples/keda_v1alpha1_clustertriggerauthentication.yaml
  • CR config/samples/keda_v1alpha1_clustertriggerauthentication.yaml is not listed in the resources section of config/samples/kustomization.yaml
  • CR config/samples/eventing_v1alpha1_cloudeventsource.yaml is not listed in the resources section of config/samples/kustomization.yaml

Also, it would be nice if we had a check to detect these sorts of problems.

Expected Behavior

No missing CRDs or CRs, neither the manifests nor the references to them in the kustomization.yaml

Actual Behavior

As described in the above description

Steps to Reproduce the Problem

Compare the repo config/crds/bases/*.yaml with config/crds/kustomize.yaml, config/samples/kustomize.yaml and config/samples/*.yaml

Logs from KEDA operator

No response

KEDA Version

2.14.0

Kubernetes Version

1.29

Platform

Red Hat OpenShift

Scaler Details

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant