Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deploy shouldn't enable opentelemetry by default #5375

Closed
zroubalik opened this issue Jan 15, 2024 · 2 comments
Closed

make deploy shouldn't enable opentelemetry by default #5375

zroubalik opened this issue Jan 15, 2024 · 2 comments
Assignees
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@zroubalik
Copy link
Member

Proposal

make deploy is usually used for development purposes of KEDA. With some recent changes, if one run this command, KEDA is configured to enable opentelemery collector.

We should revisit this approach and don't enforce opentelemetry usage. make deploy is also used to run e2e tests in our infra - there is enabling the opentelemetry collector expected.

out, err := ExecuteCommandWithDir("make deploy", "../..")

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response

@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Jan 15, 2024
@SpiritZhou
Copy link
Contributor

I think we can add a flag like AZURE_RUN_AAD_POD_IDENTITY_TESTS to enable/disable opentelemetry.

@zroubalik
Copy link
Member Author

I think more generic flag like ENABLE_OPENTELEMETRY might be better. I am okay with enabling OTEL for all e2e tests in CI, but would like to disable this by default for local development with make deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
Development

No branches or pull requests

3 participants