Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from azure-service-bus-go to azservicebus #3394

Closed
amirschw opened this issue Jul 18, 2022 · 6 comments · Fixed by #3639
Closed

Migrate from azure-service-bus-go to azservicebus #3394

amirschw opened this issue Jul 18, 2022 · 6 comments · Fixed by #3639
Assignees
@RamCohen
Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community

Comments

@amirschw
Copy link
Contributor

amirschw commented Jul 18, 2022 •
edited
Loading

Proposal

The azure-service-bus-go package was replaced by the new azservicebus package. It is recommended to migrate to the new package. Migration guide: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/messaging/azservicebus/migrationguide.md/

Use-Case

Azure service bus scaler

Anything else?

No response
@amirschw amirschw added feature-request All issues for new features that have not been committed to needs-discussion labels Jul 18, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jul 18, 2022
@zroubalik zroubalik added help wanted Looking for support from community and removed needs-discussion labels Jul 18, 2022
@zroubalik zroubalik moved this from Proposed to To Do in Roadmap - KEDA Core Jul 18, 2022
@JorTurFer
Copy link
Member

JorTurFer commented Jul 18, 2022 •
edited
Loading

we need to use golang 1.18 before because the new pkg requires 1.18. It's in my radar to update the library once we use go 1.18

@RamCohen
Copy link
Contributor

I can do that once it's possible

@JorTurFer
Copy link
Member

JorTurFer commented Jul 25, 2022 •
edited
Loading

Nice!
Maybe after next release we can take a look. AFAIR, there are problems related with the golint because some checks are not ported due to a limitation in some libraries

This was referenced Sep 9, 2022
Merged
Closed
@amirschw
Copy link
Contributor Author

Hey @JorTurFer, are there any other blockers or can this be started now that #3653 is merged?

@JorTurFer
Copy link
Member

Hey @JorTurFer, are there any other blockers or can this be started now that #3653 is merged?

It's already done here 😄
#3639

@amirschw
Copy link
Contributor Author

Cool! Missed the reference 😀

Repository owner moved this from To Do to Ready To Ship in Roadmap - KEDA Core Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RamCohen RamCohen

Labels
feature-request All issues for new features that have not been committed to help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump deps and get rid of github.com/Azure/azure-service-bus-go JorTurFer/keda
4 participants
@zroubalik @RamCohen @amirschw @JorTurFer